Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate serviceAnnotations to created Services #234

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: Propagate serviceAnnotations to created Services #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8466780
fix: Propagate serviceAnnotations to the created Services
sbernauer Oct 14, 2024
d11c549
changelog
sbernauer Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ All notable changes to this project will be documented in this file.

- Listener.status.addresses is now de-duplicated ([#231]).
- Listener controller now listens for ListenerClass updates ([#231]).
- Propagate `ListenerClass.spec.serviceAnnotations` to the created Services ([#234]).

[#231]: https://github.com/stackabletech/listener-operator/pull/231
[#234]: https://github.com/stackabletech/listener-operator/pull/234

## [24.7.0] - 2024-07-24

Expand Down
1 change: 1 addition & 0 deletions rust/operator-binary/src/listener_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ pub async fn reconcile(listener: Arc<Listener>, ctx: Arc<Ctx>) -> Result<control
.context(BuildListenerOwnerRefSnafu)?]),
// Propagate the labels from the Listener object to the Service object, so it can be found easier
labels: listener.metadata.labels.clone(),
annotations: Some(listener_class.spec.service_annotations),
..Default::default()
},
spec: Some(ServiceSpec {
Expand Down
Loading