Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate serviceAnnotations to created Services #234

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 14, 2024

Description

Reported in https://github.com/orgs/stackabletech/discussions/57

This PR actually now uses ListenerClass.spec.serviceAnnotations...

The following ListenerClass

apiVersion: listeners.stackable.tech/v1alpha1
kind: ListenerClass
metadata:
  name: lb-with-annotations
spec:
  serviceType: LoadBalancer
  serviceAnnotations:
    # networking.gke.io/load-balancer-type: Internal
    service.beta.kubernetes.io/aws-load-balancer-internal: "true"
    service.beta.kubernetes.io/aws-load-balancer-type: internal

now produces the correct annotations on the Service

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer self-assigned this Oct 14, 2024
@sbernauer sbernauer requested a review from nightkr October 14, 2024 14:53
@sbernauer sbernauer changed the title fix: Propagate serviceAnnotations to the created Services fix: Propagate serviceAnnotations to created Services Oct 14, 2024
@sbernauer sbernauer added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 3cbbac7 Oct 14, 2024
31 checks passed
@sbernauer sbernauer deleted the fix/propagate-annotations branch October 14, 2024 15:31
@lfrancke
Copy link
Member

Could you please include a short sentence we can use for the release notes?

@sbernauer
Copy link
Member Author

ListenerClass.spec.serviceAnnotations are now correctly propagated to created Service objects.

@lfrancke lfrancke added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/24.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants