Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): resource names #131

Merged
merged 4 commits into from
Jan 2, 2024
Merged

fix(helm): resource names #131

merged 4 commits into from
Jan 2, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Jan 2, 2024

Description

Fixes #128

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@razvan razvan requested a review from a team January 2, 2024 14:43
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you check if the secret op as well?

@razvan
Copy link
Member Author

razvan commented Jan 2, 2024

LGTM! Did you check if the secret op as well?

Yes. Secret is fine.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit 38c7672 Jan 2, 2024
@sbernauer
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceAccount can't be found when used as a subchart
3 participants