ServiceAccount can't be found when used as a subchart

[chris922]

Affected version

23.11.0

Current and expected behavior

I am using the listener-operator within a subchart that is named stackable-operators. Unfortunately I am getting the following error:

error looking up service account stackable-system/stackable-operators-serviceaccount: serviceaccount "stackable-operators-serviceaccount" not found

I expect that using the listener-operator within a subchart is working.

Possible solution

The listener-operator chart creates a ServiceAccount:

listener-operator/deploy/helm/listener-operator/templates/serviceaccount.yaml

Lines 4 to 6 in 3ecc840

	kind: ServiceAccount
	metadata:
	name: {{ include "operator.fullname" . }}-serviceaccount

The name is built like: {{ include "operator.fullname" . }}-serviceaccount

Having a look at the deployment this one is building the name out of a different pattern {{ .Release.Name }}-serviceaccount:

listener-operator/deploy/helm/listener-operator/templates/controller-deployment.yaml

Line 27 in 3ecc840

serviceAccountName: {{ .Release.Name }}-serviceaccount

I think the .Release.Name should not be used here and the same approach should be used to derive the service account name.

Besides that I noticed that the deployment name is also derived from the .Release.Name, this should be changed as well. In other Helm charts the deployment names will not be derived from the release-name, see for example here: https://github.com/stackabletech/commons-operator/blob/main/deploy/helm/commons-operator/templates/deployment.yaml#L5

Right now my deployment is named stackable-operators-controller-deployment cause my main chart is named stackable-operators that contains the listener-operator as a subchart.

Additional context

No response

Environment

No response

Would you like to work on fixing this bug?

None

[nightkr]

Hey, looks like you're right, stackabletech/operator-templating@2b73b32 wasn't replicated correctly here. We should also check whether secret-op has the same issue.