Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to semantics of ids parameter in STAC API 1.0.0-beta.2 #31

Open
philvarner opened this issue May 5, 2021 · 2 comments
Open

Change to semantics of ids parameter in STAC API 1.0.0-beta.2 #31

philvarner opened this issue May 5, 2021 · 2 comments
Milestone

Comments

@philvarner
Copy link
Contributor

See radiantearth/stac-api-spec#125 for details.

Summary is that the ids parameter will no longer be treated specially.

Currently in 1.0.0-beta.1, the presence of ids causes all other filter predicates to be ignored.

In 1.0.0-beta.2, ids will be treated the same as all other filter predicates and simply ANDed to them.

Since stac-fastapi actually conformed to those semantics rather than ignoring them like most every other STAC API implementation, a change will be necessary.

@bitner
Copy link
Collaborator

bitner commented May 17, 2021

Just putting a placeholder here that this will need to be changed in both sqlalchemy and pgstac backends to make sure we don't close it out for just one or the other fix.

@gadomski
Copy link
Member

gadomski commented Feb 6, 2023

Moving this out of the 2.4.4 milestone while it waits on stac-utils/pgstac#159.

@gadomski gadomski added this to the 2.5.0 milestone Feb 6, 2023
@gadomski gadomski removed their assignment Feb 6, 2023
@gadomski gadomski transferred this issue from stac-utils/stac-fastapi May 11, 2023
ivica3730k pushed a commit to SpatialDays/stac-fastapi-pgstac that referenced this issue Jun 6, 2023
* create stac-sprint dev branch

* improve local development (stac-utils#12)

* use postgis official image, update migration command

* remove comment

* update dockerfile

* improve makefile

* update readme

* add pre-commit, make pre-commit happy

* update pipfile

* add settings injection (stac-utils#13)

* add settings injection

* update cicd

* decouple transactions and core endpoints (stac-utils#14)

* define base clients, add transaction client (stac-utils#16)

* define base clients, add transaction client

* use absolute imports

* cleanup

* add transactions router factory (stac-utils#17)

* add transactions router factory

* add create_app method

* add collection router factory (stac-utils#19)

* improve postgres clients

* rename api models

* add collection router factory

* add item collection route

* add item router factory (stac-utils#20)

* standardize input (stac-utils#21)

* whoops

* remove apiresponse

* add empty request

* update endpoint

* fix some things

* configure api extensions (stac-utils#22)

* create request body models

* add stac api extensions to api settings

* helper method to check if api extension is enabled

* parametrize transaction extension

* parametrize query extension

* parametrize context extension

* parametrize field extension

* set model base

* simplify app creation (stac-utils#23)

* add tiles add on, consolidate core endpoints (stac-utils#24)

* template simple tiles router

* update dockerfile

* update pipfile

* add more tiles links

* finish tiles client

* create stac router

* request kwargs (stac-utils#25)

* pass through request

* rearrange

* remove dependency

* remove references to dependency

* fix everything

* unify core spec (stac-utils#26)

* unify core spec

* update tests

* cleanup

* update docstrings

* add get search to router factory (stac-utils#27)

* update titiler version, update openapi

* fix item uri

* updates (stac-utils#28)

* update dependencies

* updates

* update dockerfile

* add tiles link

* add wmts link, add link titles

* add api module (stac-utils#29)

* update tests, fix bugs (stac-utils#30)

* don't mutate orm objects

* oops

* update tests

* remove echo

* add api test cases

* add api test cases

* fix test

* update conformance (stac-utils#31)

* add conformance routes to factory

* remove comment

* update test

* move liveliness probe (stac-utils#32)

* enable sql echo

* optimize sql (stac-utils#33)

* faster count

* remove a select

* optimize fetching collection children

* remove id from default sort

* use a join

* fix paging

* raise notfounderror

* update test

* dont raise

* update titiler (stac-utils#34)

* update branch rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants