Fixup infrastructure and names after breakout #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhartzell
suggested changes
Apr 3, 2023
There was a problem hiding this comment.
A lot going on here. Overall, the changes look reasonable. Installs, tests pass. Only issue l've found is in the docs. INFO and WARNINGs from mkdocs serve after running make docs:
...
INFO - The following pages exist in the docs directory, but are not included in the "nav" configuration:
- api/stac_fastapi/pgstac/index.md
- api/stac_fastapi/pgstac/app.md
- api/stac_fastapi/pgstac/config.md
- api/stac_fastapi/pgstac/core.md
- api/stac_fastapi/pgstac/db.md
- api/stac_fastapi/pgstac/transactions.md
- api/stac_fastapi/pgstac/utils.md
- api/stac_fastapi/pgstac/version.md
- api/stac_fastapi/pgstac/extensions/index.md
- api/stac_fastapi/pgstac/extensions/filter.md
- api/stac_fastapi/pgstac/extensions/query.md
- api/stac_fastapi/pgstac/models/index.md
- api/stac_fastapi/pgstac/models/links.md
WARNING - A relative path to 'api/stac_fastapi/api/app.md' is included in the 'nav' configuration, which is not found in the documentation files
WARNING - A relative path to 'api/stac_fastapi/api/config.md' is included in the 'nav' configuration, which is not found in the documentation files
WARNING - A relative path to 'api/stac_fastapi/api/errors.md' is included in the 'nav' configuration, which is not found in the documentation files
...
Browsing the docs reveals dead links.
Yeah, sorry ... didn't know how to do it without doing it all at once. Shouldn't be any functional code changes though.
Fixed, I'll do the same over on sqlalchemy. |
pjhartzell
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
No functional code changes.
PR Checklist:
pre-commithooks pass locallymake test)make docs)