Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small adjustments to the Scope deep links #2

Merged
merged 1 commit into from
May 13, 2019
Merged

Small adjustments to the Scope deep links #2

merged 1 commit into from
May 13, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 10, 2019

Changes

  • Cluster now links to the clean (non-cached) Scope UI state
  • Removed all the extra pre-filtering (@squillace, I wasn't sure if you actually wanted to keep any from here)
  • Fixed the namespace selection in deep links from namespaces
  • Pod and Service views can be quite big, so I set the search query to the active node name there to highlight that node in deep links (see the screenshot below) - the proper solution of having that node selected requires Support fetching node details through node label/rank instead of ID weaveworks/scope#3122 to be implemented first

image

@squillace
Copy link
Owner

@fbarl thanks; that kind of refinement I wouldn't have been able to get to! testing now.

@squillace squillace merged commit 794c414 into squillace:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @squillace