Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching node details through node label/rank instead of ID #3122

Open
fbarl opened this issue Mar 27, 2018 · 2 comments
Open

Support fetching node details through node label/rank instead of ID #3122

fbarl opened this issue Mar 27, 2018 · 2 comments
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality

Comments

@fbarl
Copy link
Contributor

fbarl commented Mar 27, 2018

If we could call /api/topology/{name}/{id} with node labels instead of IDs, we would be able to load node details directly if only node labels were provided in the URL.

As far as I can see, this is the only backend blocker for resolving #2030 and it would only require us to do a bit more sophisticated search through nodes in handleNode in api_topology.go.

cc @rade @dlespiau

@fbarl fbarl added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Mar 27, 2018
@rade
Copy link
Member

rade commented Mar 28, 2018

What exactly do you mean by "node labels"? The label field in the json? For k8s that does contain the k8s name, but don't we also need the namespace? Note that the rank field combines namespace and name.

@fbarl
Copy link
Contributor Author

fbarl commented Mar 28, 2018

What exactly do you mean by "node labels"? The label field in the json?

Yeah, I did mean the label field originally, but it makes more sense to include namespace in the name. I guess rank is exactly what we want since for controllers it has the same format as our Deploy/Monitor workload IDs, it's just the name rank that I find confusing :P

@fbarl fbarl changed the title Support fetching node details through node label instead of ID Support fetching node details through node label/rank instead of ID Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality
Projects
None yet
Development

No branches or pull requests

2 participants