Fix public suffix process and import #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping @swankjesse |
swankjesse
reviewed
Apr 22, 2023
| */ | ||
| class PublicSuffixListGenerator( | ||
| projectRoot: Path = ".".toPath(), | ||
| val fileSystem: FileSystem = FileSystem.SYSTEM, |
There was a problem hiding this comment.
Any reference to okio.FileSystem will win my heart!
swankjesse
reviewed
Apr 22, 2023
| } | ||
|
|
||
| private suspend fun updateLocalFile() = withContext(Dispatchers.IO) { | ||
| client.newCall(request).executeAsync().use { response -> |
swankjesse
reviewed
Apr 22, 2023
| check(fileSystem.metadata(resources).isDirectory) | ||
| check(fileSystem.metadata(testResources).isDirectory) | ||
|
|
||
| updateLocalFile() |
There was a problem hiding this comment.
Having each of these functions do withContext(Dispatchers.IO), rather than pulling that dispatcher switch up here is surprising? As-is it’s correct and good though.
There was a problem hiding this comment.
I think it's that thing about making all suspend functions main safe, and that withContext(Dispatchers.IO) should be a no-op from Dispatchers.IO or Dispatchers.Default.
swankjesse
approved these changes
Apr 22, 2023
swankjesse
reviewed
Apr 22, 2023
| } | ||
| } | ||
|
|
||
| suspend fun main() { |
There was a problem hiding this comment.
Such a great language feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #7699
Next automating in CI.