PublicSuffix list looks to be quite outdated and missing recent additions

[CDRussell]

Hey 👋

I'm looking here https://github.com/square/okhttp/tree/master/okhttp/src/jvmMain/resources/okhttp3/internal/publicsuffix and seeing the public suffix list hasn't been updated in 2 years.

I ask because I noticed foo.myshopify.com and bar.myshopify.com are both returning myshopfiy.com as e-TLD+1, despite myshopify.com being on the public suffix list.

Questions

1. Is the file I linked to above just a placeholder, and an updated version is grabbed some other way, or is it really just quite outdated?
2. Is there some mechanism I should be doing outside of okhttp to provide a newer public suffix list for okhttp to consume?

Thanks!

[yschimke]

We should re-run

okhttp/okhttp/src/jvmTest/java/okhttp3/internal/publicsuffix/PublicSuffixListGenerator.java

Line 16 in 50a71e7

package okhttp3.internal.publicsuffix;

And get it into a 4.11.

[JakeWharton]

You can run it weekly on CI and have it make a PR if it has changed.

Here's an example to copy: https://github.com/mdogan/homebrew-zulu/blob/master/.github/workflows/upgrade.yml

[CDRussell]

Or since it only currently matters at the point of cutting a release, generating an updated suffix list at point of release maybe?

Would it be possible to get an idea on:

1. how likely this will be updated in the next release?
2. when that next 4.11 release might be available (days/weeks away?)

Even if you currently have no estimate to offer, knowing even that would still be useful for me to make some decisions around this. Ta!

[yschimke]

5.x PR #7700
4.x PR #7701

@swankjesse does the releases, but I don't think he'll want to give an exact date. My guess is small number of weeks rather than months.

[JakeWharton]

The ideal release process is a tag on an existing, tested SHA. Changing data at release prevents adequate testing.

[CDRussell]

Sorry for the bump, but wondering if there's likely to be any movement on this soon?

[yschimke]

It's in 4.11

https://github.com/square/okhttp/blob/master/docs/changelogs/changelog_4x.md