Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Wait until console is ready before executing code for dedicated consoles #5301

Merged
merged 9 commits into from
Oct 12, 2017
Merged

PR: Wait until console is ready before executing code for dedicated consoles #5301

merged 9 commits into from
Oct 12, 2017

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 21, 2017 •
edited
Loading

Fixes #5296
Fixes #4856

This also:

  • Waits until the prompt is ready before hiding the loading animation.
  • Increases time_to_dead check to avoid spurious prompts.

TODO:

  • Tests

@ccordoba12 ccordoba12 added this to the v3.2.4 milestone Sep 21, 2017
@pep8speaks
Copy link

pep8speaks commented Sep 21, 2017 •
edited
Loading

Hello @ccordoba12! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on October 12, 2017 at 00:05 Hours UTC

@ccordoba12 ccordoba12 mentioned this pull request Sep 21, 2017
Closed
@ccordoba12 ccordoba12 merged commit 156e869 into spyder-ide:3.x Oct 12, 2017
@ccordoba12 ccordoba12 deleted the wait-prompt-ready branch October 12, 2017 02:14
ccordoba12 added a commit that referenced this pull request Oct 12, 2017
@ccordoba12
Merge from 3.x: PR #5301
10d93f0 
Fixes #5296
Fixes #4856
@ccordoba12 ccordoba12 mentioned this pull request Oct 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @pep8speaks