PR: Wait until console It's ready before executing code. #5127
Conversation
- Fix error of banner and prompt being deleted when executing in a dedicated console.
spyder/plugins/ipythonconsole.py
Outdated
| sw.silent_execute( | ||
| 'get_ipython().kernel.close_all_mpl_figures()') | ||
| sw.reset_namespace(force=True) | ||
| elif current_client and clear_variables: | ||
| sw.reset_namespace(force=True) | ||
| # wait until console it's ready before executing code | ||
| self.wait_shell_is_ready(sw) |
There was a problem hiding this comment.
Please move this line to the if not current_client block.
|
@rlaverde does this mean that the code execution is now slower somehow, because of this timeout? or we take the same time, but simply display info at a later step? |
| loop = QEventLoop() | ||
| timer = QTimer() | ||
| timer.timeout.connect(loop.quit) | ||
| timer.start(300) |
There was a problem hiding this comment.
Are we waiting only 300 ms for the prompt to be ready?
There was a problem hiding this comment.
Ok, I saw above that timeout=3000, but this should be higher. I think we should set it to 15000 at least.
There was a problem hiding this comment.
We are waiting a maximum of 3seconds, and checking every 300ms, testing in my machine It takes ~1.5 seconds to be ready
It's a little slow the first time when executing in a dedicated console, It'll wait until console is ready before executing the script, the timeout is to avoid waiting too much time. When running in an already open console, |
What do you mean by this? What happens if the timeout is finished? |
It the console is never ready (maybe for an error in the initialization), continuing this infinite loop could hang spyder, the timeout is the maximum time to wait for the console to be ready
It'll return and the code will executed, maybe deleting the prompt, or mixing the output with the prompt |
spyder/plugins/ipythonconsole.py
Outdated
| sw.silent_execute( | ||
| 'get_ipython().kernel.close_all_mpl_figures()') | ||
| sw.reset_namespace(force=True) | ||
| # wait until console it's ready before executing code | ||
| self.wait_shell_is_ready(sw) |
There was a problem hiding this comment.
This has to be before the other two previous calls (i.e. sw.silent_execute and sw.reset_namespace) because those require a running kernel to work.
|
@ccordoba12 I moved the code, although I don't think it will be a difference, because the wait (for the banner) is necessary for commands that print something. |
|
I was not too happy with this approach because I found it a bit too complicated. So I developed #5301, which I find simpler to understand. |
Fix 1 and 2 of #4856
Fix error of banner and prompt being deleted when executing in a dedicated console.
Now It looks as expected when running in a dedicated console:
