PR: Add Spyder PYTHONPATH to PluginClient #4263
Conversation
|
@rlaverde, please add a test for this. From now on I want to see tests for every new features we add. |
spyder/plugins/editor.py
Outdated
| @@ -1462,6 +1462,8 @@ def set_current_filename(self, filename, editorwindow=None): | |||
| def set_path(self): | |||
| for finfo in self.editorstacks[0].data: | |||
| finfo.path = self.main.get_spyder_pythonpath() | |||
| if self.introspector: | |||
| self.introspector.change_spyder_path(self.main.get_spyder_pythonpath()) | |||
There was a problem hiding this comment.
It looks wider then 79 columns.
| @@ -41,7 +41,7 @@ class AsyncClient(QObject): | |||
| received = Signal(object) | |||
|
|
|||
| def __init__(self, target, executable=None, name=None, | |||
| extra_args=None, libs=None, cwd=None, env=None): | |||
| extra_args=None, libs=None, cwd=None, env=None, extra_path=None): | |||
There was a problem hiding this comment.
Move extra_paths=None to a new line below this one
| @@ -86,6 +89,11 @@ def run(self): | |||
| python_path = osp.pathsep.join([python_path, path]) | |||
| except ImportError: | |||
| pass | |||
| if self.extra_path: | |||
| try: | |||
| python_path = osp.pathsep.join([python_path] + self.extra_path) | |||
This happens because Spyder's PYTHONPATH is updated at startup and when changing projects, so i think you should try to restart plugins exactly when it's needed. |
rlaverde
force-pushed
the
fix/python-path-jedi
branch
2 times, most recently
from
9663163 to
e90fb04
Compare
- Avoid one innecessary restart at startup, - Also change the name to extra_path to make it more generic.
rlaverde
force-pushed
the
fix/python-path-jedi
branch
from
e90fb04 to
0a317fd
Compare
rlaverde
force-pushed
the
fix/python-path-jedi
branch
from
0a317fd to
f943450
Compare
|
@rlaverde, your test is failing on Windows. Please skip it there. |
|
@ccordoba12 I forget that windows use a different path separator, I added a commit to fix that test |
| @@ -77,7 +81,7 @@ def run(self): | |||
| # Set up environment variables. | |||
| processEnvironment = QProcessEnvironment() | |||
| env = self.process.systemEnvironment() | |||
| if (self.env and 'PYTHONPATH' not in self.env) or DEV: | |||
| if (self.env and 'PYTHONPATH' not in self.env) or self.env is None: | |||
There was a problem hiding this comment.
Please restore DEV here. I think it's needed to make completions work when Spyder is started with bootstrap.py
There was a problem hiding this comment.
hmm no, I tested and this condition evaluate to True when using ./bootstrap.py
I changed because previously it only evaluates to True when DEV was True (i. e. libraries, and spyder path only will be added in dev mode)
There was a problem hiding this comment.
Ok, thanks for the clarification!
|
@rlaverde, how many times are our completion plugins are restarted when switching projects? Two as before, or just one? |
|
|
The number of restarts are exactly the ones needed. Thanks for improving that! |
|
I restarted Circle again to make coveralls to pass before merging. |
ccordoba12
changed the title
…ed in the process enviroment.
…ed in the process enviroment.
…ed in the process enviroment.
Fixes #4141
I think this is ready, but this is causing plugins to be restarted at startup, (normally 1 time, and 2 times when there is a project open)
It's that ok? or how It could be avoided?