Add some unittests for Plugin Client.

spyder/utils/introspection/plugin_client.py

@@ -81,7 +81,7 @@ def run(self):
         # Set up environment variables.
         processEnvironment = QProcessEnvironment()
         env = self.process.systemEnvironment()
-        if (self.env and 'PYTHONPATH' not in self.env) or DEV:
+        if (self.env and 'PYTHONPATH' not in self.env) or self.env is None:
             python_path = osp.dirname(get_module_path('spyder'))
             # Add the libs to the python path.
             for lib in self.libs:
@@ -94,8 +94,9 @@ def run(self):
                 try:
                     python_path = osp.pathsep.join([python_path] +
                                                    self.extra_path)
-                except Exception:
-                    pass
+                except Exception as e:
+                    debug_print("Error when adding extra_path to plugin env")
+                    debug_print(e)
             env.append("PYTHONPATH=%s" % python_path)
         if self.env:
             env.update(self.env)

spyder/utils/introspection/tests/test_plugin_client.py

@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright © Spyder Project Contributors
+# Licensed under the terms of the MIT License
+#
+"""Tests for plugin_client.py."""
+
+# Test library imports
+import pytest
+
+# Local imports
+from spyder.utils.introspection.plugin_client import PluginClient
+from spyder.utils.introspection.manager import PLUGINS
+
+
+@pytest.mark.parametrize("plugin_name", PLUGINS)
+def test_plugin_client(qtbot, plugin_name):
+    """Test creation of the diferent plugin clients."""
+    plugin = PluginClient(plugin_name=plugin_name)
+
+    assert plugin
+
+
+@pytest.mark.parametrize("plugin_name", PLUGINS)
+def test_plugin_client_extra_path(qtbot, plugin_name):
+    """Test adding of extra path.
+
+    Extra path is used for adding spyder_path to plugin clients.
+    """
+    extra_path = '/some/dummy/path'
+
+    plugin = PluginClient(plugin_name=plugin_name, extra_path=[extra_path])
+    plugin.run()
+    python_path = plugin.process.processEnvironment().value('PYTHONPATH')
+    assert extra_path in python_path.split(':')
+
+
+if __name__ == "__main__":
+    pytest.main()