PR: Improve Variable Explorer UX #20868
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Preview: |
jsbautista
changed the title
There was a problem hiding this comment.
Thanks @jsbautista for the work here! Left an initial review with a comment regarding the changes related with spyder-kernels and a comment suggestion. Also, after a quick look to the tests, seems like the errors there are related with the changes here so a look to those is missing too.
If you have any question let me know!
Co-authored-by: Daniel Althviz Moré <[email protected]>
There was a problem hiding this comment.
Thanks @jsbautista for your work on this! It looks really nice!!
…s.git --branch=variableExplorerKernels --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "db201a8aa" upstream: origin: "https://github.com/jsbautista/spyder-kernels.git" branch: "variableExplorerKernels" commit: "db201a8aa" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
…s.git --branch=variableExplorerKernels --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "fd7a942a4" upstream: origin: "https://github.com/jsbautista/spyder-kernels.git" branch: "variableExplorerKernels" commit: "fd7a942a4" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
…a/spyder into VariableExplorerIssues
…a/spyder into VariableExplorerIssues
There was a problem hiding this comment.
Thanks @jsbautista for the work here! I left a suggestion for the comment regarding the mouse cursor change which seems that was missing. Also, we need to wait for spyder-ide/spyder-kernels#460 to be merged so we can update the spyder-kernels subrepo again to the main repo. But, besides that this LGTM 👍
Co-authored-by: Daniel Althviz Moré <[email protected]>
…s.git --branch=master --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "838f55d83" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "838f55d83" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
There was a problem hiding this comment.
Last small comments for you @jsbautista and @dalthviz, then this should be ready.
Co-authored-by: Carlos Cordoba <[email protected]>
Description of Changes
Fixes variable explorer UX issues
Depends on spyder-ide/spyder-kernels#460
Issue(s) Resolved
Fixes spyder-ide/ux-improvements#17
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista