-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add a global filter flag to settings #460
PR: Add a global filter flag to settings #460
Conversation
@jsbautista or @dalthviz, could you add a test for this? It could be as simple as building the namespace view with and without the filter on and checking that a specific variable is absent/present in each case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista for the work here! Left a small suggestion. Regarding the test, I think we can use as boilerplate the one at:
spyder-kernels/spyder_kernels/console/tests/test_console_kernel.py
Lines 277 to 289 in fd7a942
def test_get_namespace_view(kernel): | |
""" | |
Test the namespace view of the kernel. | |
""" | |
execute = asyncio.run(kernel.do_execute('a = 1', True)) | |
nsview = repr(kernel.get_namespace_view()) | |
assert "'a':" in nsview | |
assert "'type': 'int'" in nsview or "'type': u'int'" in nsview | |
assert "'size': 1" in nsview | |
assert "'view': '1'" in nsview | |
assert "'numpy_type': 'Unknown'" in nsview | |
assert "'python_type': 'int'" in nsview |
If you have any question let me know!
Co-authored-by: Daniel Althviz Moré <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista ! LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @jsbautista for your work on this!
@dalthviz, please squash-merge as soon as @jsbautista resolves your comment above. |
Part of spyder-ide/spyder#20868