Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix loading of external (non dockable) plugins and other fixes #13874

Merged
merged 3 commits into from
Oct 24, 2020
Merged

PR: Fix loading of external (non dockable) plugins and other fixes #13874

merged 3 commits into from
Oct 24, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Sep 28, 2020 •
edited
Loading

Description of Changes

  • Add close handling for plugins, internal and external.
  • Fix loading of external (non dockable) plugins.
  • Skip cwd changed signal emit when using an external spyder kernel.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca marked this pull request as draft September 28, 2020 16:54
@goanpeca goanpeca changed the title Add check for plugin ype on external plugins PR: Add check for plugin ype on external plugins Sep 28, 2020
@goanpeca goanpeca force-pushed the fix/external-plugin branch from b964679 to 4ecc2d2 Compare October 23, 2020 21:15
@goanpeca goanpeca marked this pull request as ready for review October 23, 2020 21:15
@goanpeca goanpeca requested a review from ccordoba12 October 23, 2020 21:15
@goanpeca
Copy link
Member Author

goanpeca commented Oct 23, 2020 •
edited
Loading

This is needed for Spyder-remote @ccordoba12.

Pinging @nerohmot

@ccordoba12 ccordoba12 added this to the v5.0alpha2 milestone Oct 23, 2020
@ccordoba12 ccordoba12 changed the title PR: Add check for plugin ype on external plugins PR: Fix loading of external (non dockable) plugins and other fixes Oct 23, 2020
ccordoba12
ccordoba12 reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca. I left a small review for you.

spyder/app/mainwindow.py Outdated Show resolved Hide resolved
spyder/app/mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/plugin.py Outdated Show resolved Hide resolved
@goanpeca goanpeca force-pushed the fix/external-plugin branch from 22d6f83 to ca06dc0 Compare October 24, 2020 15:37
@goanpeca goanpeca requested a review from ccordoba12 October 24, 2020 15:37
@goanpeca
Copy link
Member Author

Thanks for the feedback @ccordoba12. Made the requested fixes.

ccordoba12
ccordoba12 approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca, looks good to me now.

@ccordoba12 ccordoba12 merged commit 5ad4244 into spyder-ide:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@ccordoba12 ccordoba12

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
v5.0alpha2
Development

Successfully merging this pull request may close these issues.
2 participants
@goanpeca @ccordoba12