Add code review fixes.

spyder-ide · Oct 24, 2020 · ca06dc0 · ca06dc0
1 parent 4ecc2d2
commit ca06dc0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/spyder/app/mainwindow.py b/spyder/app/mainwindow.py
@@ -3000,7 +3000,6 @@ def closing(self, cancelable=False):
             try:
                 if isinstance(plugin, SpyderDockablePlugin):
                     plugin.close_window()
-
                 if not plugin.on_close(cancelable):
                     return False
             except AttributeError:
@@ -3011,7 +3010,6 @@ def closing(self, cancelable=False):
                 plugin._close_window()
                 if not plugin.closing_plugin(cancelable):
                     return False
-
             except AttributeError:
                 pass
 
@@ -3023,7 +3021,6 @@ def closing(self, cancelable=False):
 
                 if not plugin.on_close(cancelable):
                     return False
-
             except AttributeError as e:
                 logger.error(str(e))
 

diff --git a/spyder/plugins/ipythonconsole/plugin.py b/spyder/plugins/ipythonconsole/plugin.py
@@ -624,7 +624,7 @@ def set_working_directory(self, dirname):
         """Set current working directory.
         In the workingdirectory and explorer plugins.
         """
-        if not self.get_current_client().external_kernel:
+        if osp.isdir(dirname):
             self.sig_current_directory_changed.emit(dirname)
 
     def update_working_directory(self):