Make Saml2AuthenticationToken Serializable #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996, for the PR!
In addition to my inline feedback, will you please add Closes gh-16286 to the end of your commit message?
...org/springframework/security/saml2/provider/service/registration/AssertingPartyMetadata.java
Show resolved
Hide resolved
...g/src/test/java/org/springframework/security/SpringSecurityCoreVersionSerializableTests.java
Show resolved
Hide resolved
jzheaux
added
type: bug
|
Thanks for your review. I will rebase commit into below message if my PR does not have any changes. |
|
Please review and tell me if I missunderstood |
jzheaux
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks for the updates, @ngocnhan-tran1996. This is close. I've left feedback inline.
...vice-provider/src/main/java/org/springframework/security/saml2/core/Saml2X509Credential.java
Outdated
Show resolved
Hide resolved
ngocnhan-tran1996
force-pushed
the
gh-16286
branch
3 times, most recently
from
be97a2b to
bbc8e69
Compare
jzheaux
approved these changes
Jan 31, 2025
|
Thanks, @ngocnhan-tran1996! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16286