Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Saml2AuthenticationToken Serializable #16286

Closed
jzheaux opened this issue Dec 13, 2024 · 1 comment · Fixed by #16287
Closed

Make Saml2AuthenticationToken Serializable #16286

jzheaux opened this issue Dec 13, 2024 · 1 comment · Fixed by #16287
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug
Milestone
6.4.x

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 13, 2024

Saml2AuthenticationToken implements Serializable, but cannot be serialized due to RelyingPartyRegistration, one of its members, not being serializable.
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules labels Dec 13, 2024
@jzheaux jzheaux added this to the 6.4.x milestone Dec 13, 2024
@ngocnhan-tran1996 ngocnhan-tran1996 mentioned this issue Dec 15, 2024
Merged
ngocnhan-tran1996 added a commit to ngocnhan-tran1996/spring-security that referenced this issue Dec 21, 2024
@ngocnhan-tran1996
Merge branch 'main' of https://github.com/spring-projects/spring-secu…
9954101 
…rity into spring-projectsgh-16286
ngocnhan-tran1996 added a commit to ngocnhan-tran1996/spring-security that referenced this issue Dec 21, 2024
@ngocnhan-tran1996
Add Serializable for RelyingPartyRegistration
ee25efa 
Closes spring-projectsgh-16286
ngocnhan-tran1996 added a commit to ngocnhan-tran1996/spring-security that referenced this issue Dec 21, 2024
@ngocnhan-tran1996
Add Serializable for RelyingPartyRegistration
bbc8e69 
Closes spring-projectsgh-16286

Generate file serialized

Generate file serialized
jzheaux pushed a commit to ngocnhan-tran1996/spring-security that referenced this issue Jan 31, 2025
@ngocnhan-tran1996 @jzheaux
Make RelyingPartyRegistration Serializable
3ef203a 
Closes spring-projectsgh-16286
jzheaux added a commit to ngocnhan-tran1996/spring-security that referenced this issue Jan 31, 2025
@jzheaux
Make Saml2AuthenticationToken Serializable
4b5bacf 
Issue spring-projectsgh-16286
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Jan 31, 2025
@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 31, 2025

Closed in favor of #16287

jzheaux pushed a commit that referenced this issue Feb 3, 2025
@ngocnhan-tran1996 @jzheaux
Make RelyingPartyRegistration Serializable
bcc4b41 
Closes gh-16286
jzheaux added a commit that referenced this issue Feb 3, 2025
@jzheaux
Make Saml2AuthenticationToken Serializable
5ff8712 
Issue gh-16286
jzheaux added a commit that referenced this issue Feb 3, 2025
@jzheaux
Ensure Serialization Compatibility for AuthenticationException
47fd6be 
Issue gh-16286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
6.4.x
Development

Successfully merging a pull request may close this issue.

Make Saml2AuthenticationToken Serializable ngocnhan-tran1996/spring-security
1 participant
@jzheaux