Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitattributes #28476

Closed
snicoll opened this issue Oct 28, 2021 · 6 comments
Closed

Add .gitattributes #28476

snicoll opened this issue Oct 28, 2021 · 6 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@snicoll
Copy link
Member

snicoll commented Oct 28, 2021

See #27615, we need to revert due to our windows build failing, see spring-io/spring-javaformat#280.
@snicoll snicoll added the type: task A general task label Oct 28, 2021
@snicoll snicoll added this to the 2.4.x milestone Oct 28, 2021
@snicoll snicoll mentioned this issue Oct 28, 2021
Closed
@Goooler
Copy link
Contributor

Goooler commented Oct 28, 2021

ok

snicoll added a commit that referenced this issue Oct 28, 2021
@snicoll
Revert "Add .gitattributes"
a8eed97 
See gh-28476
@wilkinsona wilkinsona mentioned this issue Oct 28, 2021
Closed
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.5.x Nov 15, 2021
@snicoll snicoll mentioned this issue Dec 17, 2021
Closed
@snicoll snicoll modified the milestones: 2.5.x, 2.6.x May 18, 2022
@snicoll
Copy link
Member Author

snicoll commented May 18, 2022

Closing as #28476 moved to 2.6.x.

@snicoll snicoll closed this as completed May 18, 2022
@snicoll snicoll removed this from the 2.6.x milestone May 18, 2022
@snicoll snicoll added the status: superseded An issue that has been superseded by another label May 18, 2022
@snicoll snicoll reopened this May 18, 2022
@snicoll snicoll removed the status: superseded An issue that has been superseded by another label May 18, 2022
@snicoll snicoll added this to the 2.6.x milestone May 18, 2022
@wilkinsona wilkinsona mentioned this issue Jul 20, 2022
Closed
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.7.x Nov 24, 2022
@mhalbritter
Copy link
Contributor

This PR could maybe fix that issue: spring-io/spring-javaformat#340

@ParkerM
Copy link

ParkerM commented Mar 3, 2023

@mhalbritter The fix should be in place as of 2.7.9 (#34329) and 3.0.3 (#34330).

@mhalbritter mhalbritter added status: invalid An issue that we don't feel is valid and removed type: task A general task labels Mar 6, 2023
@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@mhalbritter

This comment was marked as outdated.

Sign in to view
@mhalbritter mhalbritter removed this from the 2.7.x milestone Mar 6, 2023
@mhalbritter mhalbritter reopened this Mar 6, 2023
@mhalbritter mhalbritter removed the status: invalid An issue that we don't feel is valid label Mar 6, 2023
@mhalbritter mhalbritter added the type: task A general task label Mar 6, 2023
@mhalbritter mhalbritter added this to the 2.7.x milestone Mar 6, 2023
@philwebb
Copy link
Member

philwebb commented Nov 8, 2023

Given the risk involved in introducing this, we've decided to not pursue it for now.

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
@philwebb philwebb removed this from the 2.7.x milestone Nov 8, 2023
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@snicoll @philwebb @wilkinsona @ParkerM @Goooler @mhalbritter