Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Considering building PRs on Windows CI #28477

Closed
wilkinsona opened this issue Oct 28, 2021 · 1 comment
Closed

Considering building PRs on Windows CI #28477

wilkinsona opened this issue Oct 28, 2021 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@wilkinsona
Copy link
Member

To catch problems like #28476 (comment) earlier, I think it would be good to build PRs on Windows in addition to the existing Linux-based job.

@trevormarshall is our Windows worker sufficiently locked down that this would be a reasonable thing to do?
@wilkinsona wilkinsona added type: task A general task for: team-attention An issue we'd like other members of the team to review labels Oct 28, 2021
@wilkinsona
Copy link
Member Author

wilkinsona commented Oct 29, 2021 •
edited
Loading

On second thoughts, @trevormarshall, don't worry about this for now. Sorry for the noise. I think we need to stabilise the existing Windows CI jobs before building PRs on Windows too. As things stand, a check on Windows would report too many false-positive failures to contributors. I'll decline this one, for now at least.

@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkinsona