Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of image building plugin integration tests #25838

Closed
scottfrederick opened this issue Mar 30, 2021 · 1 comment
Closed

Improve performance of image building plugin integration tests #25838

scottfrederick opened this issue Mar 30, 2021 · 1 comment
Assignees
@scottfrederick
Labels
type: task A general task
Milestone
2.3.11

Comments

@scottfrederick
Copy link
Contributor

The Gradle plugin BootBuildImageIntegrationTests and Maven plugin BuildImageTests are designed to test the integration between the build plugins and a CNB builder. These tests take a lot of time to run because they use the default Paketo builder to build images and then verify that the images can be run. We'd like to reduce the time it takes to run these tests by using a test harness in place of the Paketo builder and do the full Paketo integration testing less frequently as described in #25824.
@scottfrederick scottfrederick self-assigned this Mar 30, 2021
@scottfrederick scottfrederick added the type: task A general task label Mar 30, 2021
@scottfrederick scottfrederick added this to the 2.3.x milestone Mar 30, 2021
@scottfrederick scottfrederick mentioned this issue Mar 30, 2021
Closed
@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.10 Mar 31, 2021
@philwebb philwebb mentioned this issue Apr 7, 2021
Open
@philwebb philwebb reopened this Apr 7, 2021
@philwebb
Copy link
Member

philwebb commented Apr 7, 2021

Reopening to see if we can fix the Docker rate limiting issues and to also consider if we should move src/spring-boot-builder

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Apr 7, 2021
philwebb added a commit that referenced this issue Apr 7, 2021
@philwebb
Attempt to overcome Docker rate limiting on CI
51d57e1 
Update the common build script to pull buildpack images early using the
authenticated CLI.

See gh-25838
wilkinsona added a commit that referenced this issue Apr 7, 2021
@wilkinsona
Revert "Use test harness for image building integration tests"
b35d1ec 
This reverts commit da9d8d6.

See gh-25838
@scottfrederick scottfrederick mentioned this issue Apr 7, 2021
Closed
@scottfrederick scottfrederick modified the milestones: 2.3.10, 2.3.x Apr 12, 2021
wilkinsona added a commit that referenced this issue Apr 15, 2021
@wilkinsona
Revert "Attempt to overcome Docker rate limiting on CI"
01fb599 
This reverts commit 51d57e1.

See gh-25838
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Apr 16, 2021
@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.11 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottfrederick scottfrederick

Labels
type: task A general task
Projects
None yet
Milestone
2.3.11
Development

No branches or pull requests
2 participants
@scottfrederick @philwebb