Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker rate limits reached in BootBuildImageIntegrationTests #25889

Closed
dreis2211 opened this issue Apr 6, 2021 · 5 comments
Closed

Docker rate limits reached in BootBuildImageIntegrationTests #25889

dreis2211 opened this issue Apr 6, 2021 · 5 comments
Labels
status: duplicate A duplicate of another issue

Comments

@dreis2211
Copy link
Contributor

Hi,

I think BootBuildImageIntegrationTests needs to be revisited again. It's hitting Docker's rate limits on CI: https://ge.spring.io/s/ratf3z65ld4wk/tests/:spring-boot-project:spring-boot-tools:spring-boot-gradle-plugin:test/org.springframework.boot.gradle.tasks.bundling.BootBuildImageIntegrationTests/buildsImageWithPullPolicy()%5B4%5D#1

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 6, 2021
@scottfrederick
Copy link
Contributor

In the 2.4.x and 2.5.x branches, most tests set pullPolicy=IF_NOT_PRESENT to minimize the number of times the test builder image is pulled from Docker Hub. With this latest round of rate-limit errors, all tests failures were in the one test (BootBuildImageIntegrationTests.buildsImageWithPullPolicy()) that forces the builder image to be pulled to verify that the pullPolicy option is working correctly. I'm not sure how much more we can do in the tests to reduce the chances of hitting rate limits.

We are investigating adding infrastructure to the Spring CI to proxy images from Docker Hub to help alleviate rate limits in builds across all Spring projects. In the interim we'll continue to monitor the situation.

@dreis2211
Copy link
Contributor Author

dreis2211 commented Apr 6, 2021

@scottfrederick My naive idea was to pull out BootBuildImageIntegrationTests.buildsImageWithPullPolicy() of the GradleCompatibility build and just test with one Gradle version. The combinations with configuration-cache on and off have extended the variations quite a bit - and therefore the pressure on rate limits.

@dreis2211
Copy link
Contributor Author

The latest round failed in more places: https://ge.spring.io/s/4dujcww2bgf2g

@scottfrederick
Copy link
Contributor

Yes, we are aware and are monitoring it. All projects building on ci.spring.io share the same rate limits so it's likely there's an unusually high level of contention right now.

@scottfrederick
Copy link
Contributor

Closing this issue in favor of re-opening #25838 to investigate why the custom builder image pulls are behaving differently than Paketo image pulls.

@scottfrederick scottfrederick removed the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2021
@snicoll snicoll added the status: duplicate A duplicate of another issue label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants