Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space between closing generic bracket and extends keyword #363

Closed
izeye opened this issue Feb 21, 2023 · 5 comments
Closed

Missing space between closing generic bracket and extends keyword #363

izeye opened this issue Feb 21, 2023 · 5 comments
Labels
type: bug
Milestone
0.0.38

Comments

@izeye
Copy link
Contributor

izeye commented Feb 21, 2023

The formatter removes spaces between class' closing generic bracket and extends keyword since 0.0.36.

See https://github.com/micrometer-metrics/micrometer/pull/3662/files#diff-82b97272c72542a13d735cc85463667675ff2f18c4d8dfd9ff4e2753b2ca6262R29 for example.
@izeye izeye mentioned this issue Feb 21, 2023
Merged
@philwebb
Copy link
Contributor

dag nam it!

@philwebb philwebb changed the title Missing space between closing generic bracket and extends keyword Missing space between closing generic bracket and extends keyword Feb 22, 2023
@philwebb philwebb added this to the 0.0.37 milestone Feb 22, 2023
@philwebb
Copy link
Contributor

It turns out that #348 needs to be selective about when insert_space_after_closing_angle_bracket_in_type_parameters is set to insert/do not insert.

@philwebb philwebb reopened this Feb 22, 2023
@philwebb
Copy link
Contributor

I'm seeing the same issue with 0.0.37 formatting Spring Boot 3.0.x

@philwebb
Copy link
Contributor 

public class UnresolvedGenericProperties<B extends Number, C>extends AbstractGenericProperties<String, B, C> {

}

@philwebb
Copy link
Contributor

👀 eclipse-jdt/eclipse.jdt.core@f2bcccf

@philwebb philwebb modified the milestones: 0.0.37, 0.0.38 Feb 22, 2023
izeye added a commit to izeye/micrometer that referenced this issue Feb 22, 2023
@izeye
Upgrade to Spring Java Format 0.0.38
53a98c4 
This commit also applies updated formatting that fixes spring-io/spring-javaformat#363.
@izeye izeye mentioned this issue Feb 22, 2023
Merged
shakuzen pushed a commit to micrometer-metrics/micrometer that referenced this issue Feb 22, 2023
@izeye
Upgrade to Spring Java Format 0.0.38 (#3665)
96aca15 
This commit also applies updated formatting that fixes spring-io/spring-javaformat#363.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.0.38
Development

No branches or pull requests
2 participants
@philwebb @izeye