Upgrade to Spring Java Format 0.0.36 #3662

izeye · 2023-02-21T23:32:19Z

This PR upgrades to Spring Java Format 0.0.36.

This PR also applies updated formatting.

See https://github.com/spring-io/spring-javaformat/releases/tag/v0.0.36

This commit also applies updated formatting. See https://github.com/spring-io/spring-javaformat/releases/tag/v0.0.36

sonatype-lift · 2023-02-21T23:45:58Z

...tions/micrometer-registry-new-relic/src/main/java/io/micrometer/newrelic/NewRelicConfig.java

-                secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),
-                "is required when publishing to Insights API", InvalidReason.MISSING).orElse(null);
+        return getSecret(this, "accountId")
+            .invalidateWhen(secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),


YodaCondition: The non-constant portion of an equals check generally comes first.

Suggested change

.invalidateWhen(secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),

.invalidateWhen(secret -> isBlank(secret) && Objects.equals(clientProviderType(), ClientProviderType.INSIGHTS_API),

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:00Z

...tions/micrometer-registry-new-relic/src/main/java/io/micrometer/newrelic/NewRelicConfig.java

-                secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),
-                "is required when publishing to Insights API", InvalidReason.MISSING).orElse(null);
+        return getSecret(this, "apiKey")
+            .invalidateWhen(secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),


YodaCondition: The non-constant portion of an equals check generally comes first.

Suggested change

.invalidateWhen(secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),

.invalidateWhen(secret -> isBlank(secret) && Objects.equals(clientProviderType(), ClientProviderType.INSIGHTS_API),

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:02Z

micrometer-core/src/main/java/io/micrometer/core/aop/TimedAspect.java

+                .tags(EXCEPTION_TAG, exceptionClass)
+                .tags(tagsBasedOnJoinPoint.apply(pjp))
+                .publishPercentileHistogram(timed.histogram())
+                .publishPercentiles(timed.percentiles().length == 0 ? null : timed.percentiles())


NullTernary: This conditional expression may evaluate to null, which will result in an NPE when the result is unboxed.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:04Z

micrometer-core/src/main/java/io/micrometer/core/instrument/Timer.java

-                .publishPercentiles(timed.percentiles().length > 0 ? timed.percentiles() : null);
+            .description(timed.description().isEmpty() ? null : timed.description())
+            .publishPercentileHistogram(timed.histogram())
+            .publishPercentiles(timed.percentiles().length > 0 ? timed.percentiles() : null);


NullTernary: This conditional expression may evaluate to null, which will result in an NPE when the result is unboxed.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:06Z

...entations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java

+                        }
+
+                        try {
+                            DateTimeFormatter.ofPattern(format);


ReturnValueIgnored: Return value of 'ofPattern' must be used

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:08Z

...ometer-core/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyClientMetrics.java

+                    .description("Content sizes for Jetty HTTP client requests")
+                    .tags(httpRequestTags)
+                    .register(registry)
+                    .record(requestLength);


LongDoubleConversion: Conversion from long to double may lose precision; use an explicit cast to double if this was intentional

Suggested change

.record(requestLength);

.record((double) requestLength);

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:10Z

...rometer-registry-appoptics/src/main/java/io/micrometer/appoptics/AppOpticsMeterRegistry.java

-                    decimal(summary.count()), Fields.Sum.tag(), decimal(summary.totalAmount()), Fields.Max.tag(),
-                    decimal(summary.max())));
+            return Optional
+                .of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal(summary.count()),


LongDoubleConversion: Conversion from long to double may lose precision; use an explicit cast to double if this was intentional

Suggested change

.of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal(summary.count()),

.of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal((double) summary.count()),

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:12Z

...les/micrometer-samples-core/src/main/java/io/micrometer/core/samples/KafkaMetricsSample.java

-        Flux.interval(Duration.ofMillis(10)).doOnEach(n -> producer.send(new ProducerRecord<>(TOPIC, "hello", "world")))
-                .subscribe();
+        Flux.interval(Duration.ofMillis(10))
+            .doOnEach(n -> producer.send(new ProducerRecord<>(TOPIC, "hello", "world")))


FutureReturnValueIgnored: Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:14Z

...registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java

-            .failedMessage("A single object was allocated that exceeded 50% of the total size of the eden space.")
-            .baseUnit("allocations").requires(new JvmGcMetrics())
-            .count(s -> s.name("jvm.gc.pause").tag("cause", "G1 Humongous Allocation")).isEqualTo(0) };
+    public static final ServiceLevelObjective[] ALLOCATIONS = new ServiceLevelObjective[] {


MutablePublicArray: Non-empty arrays are mutable, so this public static final array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:16Z

...eter-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmHeapPressureMetrics.java

-                    final long usedAfter = longLivedPoolNames.stream().mapToLong(pool -> after.get(pool).getUsed())
-                            .sum();
+                    final long usedAfter = longLivedPoolNames.stream()
+                        .mapToLong(pool -> after.get(pool).getUsed())


NULLPTR_DEREFERENCE: null (last assigned on line 131) is dereferenced.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:18Z

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetrics.java

-            final long longLivedBefore = longLivedPoolNames.stream().mapToLong(pool -> before.get(pool).getUsed())
-                    .sum();
+            final long longLivedBefore = longLivedPoolNames.stream()
+                .mapToLong(pool -> before.get(pool).getUsed())


NULLPTR_DEREFERENCE: null (last assigned on line 210) is dereferenced.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:20Z

...registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java

-                    .value(s -> s.name("jvm.gc.overhead")).isLessThan(0.5),
+                .failedMessage("Memory cleaning is taking more than 50% of CPU resources on average. "
+                        + "This usually means really serious problems with memory resulting in high performance degradation.")
+                .requires(new JvmHeapPressureMetrics())


RESOURCE_LEAK: resource of type io.micrometer.core.instrument.binder.jvm.JvmHeapPressureMetrics acquired by call to new() at line 47 is not released after line 49.

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java 79

implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java 41

implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java 59

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:23Z

...ter-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java

+            Gauge
+                .builder("cache.near.evictions", cache,
+                        cache -> getDouble(cache.getLocalMapStats(),
+                                (stats) -> stats.getNearCacheStats().getEvictions()))


NULL_DEREFERENCE: object returned by stats.getNearCacheStats() could be null and is dereferenced at line 207.

❗❗ 5 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java 215

micrometer-core/src/main/java/io/micrometer/core/instrument/composite/CompositeTimer.java 134

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java 198

micrometer-core/src/main/java/io/micrometer/core/instrument/composite/CompositeLongTaskTimer.java 85

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java 190

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:25Z

...c/main/java/io/micrometer/core/instrument/binder/grpc/MetricCollectingServerInterceptor.java

+        return this.counterCustomizer
+            .apply(prepareCounterFor(method, METRIC_NAME_SERVER_REQUESTS_RECEIVED,
+                    "The total number of requests received"))
+            .register(this.registry);


THREAD_SAFETY_VIOLATION: Read/Write race. Non-private method MetricCollectingServerInterceptor.newRequestCounterFor(...) indirectly reads without synchronization from container this.registry.meterMap via call to Map.get(...). Potentially races with write in method MetricCollectingServerInterceptor.newResponseCounterFor(...).
Reporting because a superclass class io.grpc.ServerInterceptor is annotated @ThreadSafe, so we assume that this method can run in parallel with other non-private methods in the class (including itself).

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/grpc/MetricCollectingServerInterceptor.java 123

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/grpc/MetricCollectingClientInterceptor.java 95

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/grpc/MetricCollectingClientInterceptor.java 103

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-21T23:46:27Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3662.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3662.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

izeye · 2023-02-21T23:50:02Z

...ions/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/SpectatorToDoubleGauge.java

@@ -26,7 +26,7 @@
 * identical to com.netflix.spectator.api.ObjectGauge which is not accessible in
 * Spectator.
 */
-class SpectatorToDoubleGauge<T> extends AbstractMeter<T> implements Gauge {
+class SpectatorToDoubleGauge<T>extends AbstractMeter<T> implements Gauge {


See spring-io/spring-javaformat#363

Oh wow. I didn't even know that's valid Java.

Upgrade to Spring Java Format 0.0.36

1de164e

This commit also applies updated formatting. See https://github.com/spring-io/spring-javaformat/releases/tag/v0.0.36

sonatype-lift bot reviewed Feb 21, 2023

View reviewed changes

izeye commented Feb 21, 2023

View reviewed changes

shakuzen added the type: task A general task label Feb 22, 2023

shakuzen added this to the 1.9.9 milestone Feb 22, 2023

shakuzen merged commit d00abb9 into micrometer-metrics:1.9.x Feb 22, 2023

izeye deleted the spring-java-format-0.0.36 branch February 22, 2023 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Spring Java Format 0.0.36 #3662

Upgrade to Spring Java Format 0.0.36 #3662

izeye commented Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot Feb 21, 2023

sonatype-lift bot commented Feb 21, 2023

izeye Feb 21, 2023

shakuzen Feb 22, 2023

	.invalidateWhen(secret -> isBlank(secret) && ClientProviderType.INSIGHTS_API.equals(clientProviderType()),
	.invalidateWhen(secret -> isBlank(secret) && Objects.equals(clientProviderType(), ClientProviderType.INSIGHTS_API),

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	.of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal(summary.count()),
	.of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal((double) summary.count()),

File Path	Line Number
implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java	79
implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java	41
implementations/micrometer-registry-health/src/main/java/io/micrometer/health/objectives/JvmServiceLevelObjectives.java	59

Upgrade to Spring Java Format 0.0.36 #3662

Upgrade to Spring Java Format 0.0.36 #3662

Conversation

izeye commented Feb 21, 2023

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 21, 2023

Choose a reason for hiding this comment

sonatype-lift bot commented Feb 21, 2023

🛠 Lift Auto-fix

Footnotes

izeye Feb 21, 2023

Choose a reason for hiding this comment

shakuzen Feb 22, 2023

Choose a reason for hiding this comment