Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI defaults to dark mode regardles of OS settings #211

Closed
philwebb opened this issue Feb 22, 2024 · 0 comments
Closed

UI defaults to dark mode regardles of OS settings #211

philwebb opened this issue Feb 22, 2024 · 0 comments

Comments

@philwebb
Copy link
Contributor

matchMedia('(prefers-color-scheme: dark)') is used in a few of the templates but it returns a MediaQueryList so we should add an additional ?.matches to actually check the result.

I will update PR #206 with a fix.
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 22, 2024
@philwebb
Check actual .matches result with matchMedia calls
6d6fc57 
Fixes spring-iogh-211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 22, 2024
@philwebb
Check actual .matches result with matchMedia calls
ab81458 
Fixes spring-iogh-211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 22, 2024
@philwebb
Check actual .matches result with matchMedia calls
856df8f 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 27, 2024
@philwebb
Check actual .matches result with matchMedia calls
60f84ce 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 27, 2024
@philwebb
Check actual .matches result with matchMedia calls
cf5711e 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 28, 2024
@philwebb
Check actual .matches result with matchMedia calls
17c4a0a 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 28, 2024
@philwebb
Check actual .matches result with matchMedia calls
280a584 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Mar 5, 2024
@philwebb
Check actual .matches result with matchMedia calls
3429be3 
Fixes spring-io#211
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Mar 5, 2024
@philwebb
Check actual .matches result with matchMedia calls
a7af60c 
Fixes spring-io#211
oodamien pushed a commit that referenced this issue Mar 6, 2024
@philwebb
feat: Various updates
ebfd571 
Close #199 #200 #201 #202 #203 #204 #205 #115 #211
@oodamien oodamien closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oodamien @philwebb