Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase CSS on top of stock Antora UI #205

Closed
philwebb opened this issue Feb 21, 2024 · 0 comments
Closed

Rebase CSS on top of stock Antora UI #205

philwebb opened this issue Feb 21, 2024 · 0 comments
Assignees
@oodamien

Comments

@philwebb
Copy link
Contributor

Our current CSS is a mixture of files provided by antora-ui-default and those that have been added from https://github.com/spring-io/spring-asciidoctor-backends. Unfortunately, this causes quite a few clashes in the CSS as one set of styles "fights' another.

There have been a number of updates to the antora-ui-default which we should adopt, but they are hard to merge given the fact that our own CSS is overriding things.

I think that we can improve the situation by reverting to the stock antora-ui-default then applying our updates on top. This should hopefully make it easier to keep in sync with the stock UI and make it clearer what changes we have made and why,

I have prototype code which I will submit as a PR for review.
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 21, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
26b36c6 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 21, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
3a84b40 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 22, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
83bc3d6 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 27, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
bef7eab 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 27, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
62a93bd 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 28, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
536889c 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Feb 28, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
78e4c81 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Mar 5, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
e34f239 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
philwebb added a commit to philwebb/antora-ui-spring that referenced this issue Mar 5, 2024
@philwebb
Unify CSS and rebase on antora-default-ui
234e7dd 
Refactor existing CSS to build on top of antora-default-ui CSS.
This update allows us to apply our CSS tweaks on top of the
standard Antora UI which should help us keep it in sync.

In addition, the updated CSS provides the following changes:

- Admon block styling has been updated to improve the look
- Reduced contrast is now used for the dark theme
- Callout formatting has been improved
- The breadcrumb area has been moved to allow the main
  <article> tag to have the `doc` class applied. Without this
  change the default Antora CSS does not apply correctly.
- Anchor hover positions have been improved.
- Toolbox and Tab buttons have hover colors.
- Tables can scroll horizontally when there is unbreakable
  content.
- Spring specific css is prefixed with `spring-` to make the
  files easier to find from browser devtools.
- Page bounce has been disabled

Closes spring-io#205
oodamien pushed a commit that referenced this issue Mar 6, 2024
@philwebb
feat: Various updates
ebfd571 
Close #199 #200 #201 #202 #203 #204 #205 #115 #211
@oodamien oodamien closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oodamien oodamien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oodamien @philwebb