Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Spring Cloud Function version #608

Merged

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 17, 2025

This commit overrides the spring-cloud-function version manged by spring-cloud-dependencies from 4.2.0 to 4.2.1-SNAPSHOT in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as FactoryBean.

See #599

@artembilan
Copy link
Member

Not related to the subject, but still good to see what is going on with our new tool DCO.

I think this is not very legit, Chris:

Signed-off-by: Chris Bono <[email protected]>

Such an email does not exist any more.
Plus we have discussed that org members no need this -s.
However, it turned out that we need GPG signature for our commits instead.
In the end it might be just personal preferences: -s could be very handy when you contribute to external projects 😅.
No need to do anything: just thinking aloud to share my pain making SSH signature today for my commits .

@onobc onobc requested a review from artembilan January 17, 2025 03:03
@onobc
Copy link
Collaborator Author

onobc commented Jan 17, 2025

Not related to the subject, but still good to see what is going on with our new tool DCO.

I think this is not very legit, Chris:

Signed-off-by: Chris Bono <[email protected]>

Such an email does not exist any more. Plus we have discussed that org members no need this -s. However, it turned out that we need GPG signature for our commits instead. In the end it might be just personal preferences: -s could be very handy when you contribute to external projects 😅. No need to do anything: just thinking aloud to share my pain making SSH signature today for my commits .

Ahh yeh, good catch. This was already set in intellij "Sign off commit" so was adding it automatically. i did the same thing in #608

Let me remove these from commit message (in both) and add GPG signature before merge. I will do that tomorrow though.

This commit overrides the `spring-cloud-function` version
manged by `spring-cloud-dependencies` from `4.2.0` to `4.2.1-SNAPSHOT`
in order to pickup spring-cloud/spring-cloud-function#1224
which brings the fix for functions declared as `FactoryBean`.

See spring-cloud#599
@onobc onobc force-pushed the GH-599-override-springcloudfunction branch from 222a6fb to 4c05eed Compare January 17, 2025 17:55
@artembilan artembilan merged commit f233f46 into spring-cloud:main Jan 17, 2025
2 checks passed
@onobc onobc deleted the GH-599-override-springcloudfunction branch January 17, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants