Fix FunctionTypeUtils for FactoryBean
#1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function bean can be declared as a `FactoryBean`, for example with Spring Integration's `GatewayProxyFactoryBean`. See `LogConsumerConfiguration` in Spring Functions Catalog project. * Fix `FunctionTypeUtils` to react to the `ParameterizedType` and check its assignments against `Factory` bean. Then resolves its generic to the proper target function type. * Add `BeanFactoryAwareFunctionRegistryTests.functionFromFactoryBeanIsProperlyResolved()` to verify that `FactoryBean<Function<?, ?>>` is resolved properly
artembilan
added a commit
to spring-cloud/spring-functions-catalog
that referenced
this pull request
Dec 26, 2024
The PR for Spring Cloud Function spring-cloud/spring-cloud-function#1224 brings the fix for functions declared as `FactoryBean`
onobc
added a commit
to onobc/stream-applications
that referenced
this pull request
Jan 17, 2025
This commit overrides the `spring-cloud-function` version manged by `spring-cloud-dependencies` from `4.2.0` to `4.2.1-SNAPSHOT` in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`. See spring-cloud#599 Signed-off-by: Chris Bono <[email protected]>
onobc
added a commit
to onobc/spring-functions-catalog
that referenced
this pull request
Jan 17, 2025
This replaces the use of `spring-cloud-dependencies` in time-spel-log with `spring-cloud-function-dependencies` in order to: - narrow dependencies to only what the sample needs - pick up spring-cloud/spring-cloud-function#1224 which will be released earlier than Spring Cloud `2024.0.1` in Spring Cloud Function `4.2.1` Signed-off-by: Chris Bono <[email protected]>
onobc
added a commit
to onobc/stream-applications
that referenced
this pull request
Jan 17, 2025
This commit overrides the `spring-cloud-function` version manged by `spring-cloud-dependencies` from `4.2.0` to `4.2.1-SNAPSHOT` in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`. See spring-cloud#599
artembilan
pushed a commit
to spring-cloud/stream-applications
that referenced
this pull request
Jan 17, 2025
This commit overrides the `spring-cloud-function` version manged by `spring-cloud-dependencies` from `4.2.0` to `4.2.1-SNAPSHOT` in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`. See #599
onobc
added a commit
to onobc/stream-applications
that referenced
this pull request
Jan 23, 2025
This updates spring-cloud-function to 4.2.1 in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`.
onobc
added a commit
to onobc/stream-applications
that referenced
this pull request
Jan 23, 2025
This updates spring-cloud-function to 4.2.1 in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`.
artembilan
pushed a commit
to spring-cloud/stream-applications
that referenced
this pull request
Jan 23, 2025
This updates spring-cloud-function to 4.2.1 in order to pickup spring-cloud/spring-cloud-function#1224 which brings the fix for functions declared as `FactoryBean`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function bean can be declared as a
FactoryBean, for example with Spring Integration'sGatewayProxyFactoryBean. SeeLogConsumerConfigurationin Spring Functions Catalog project.FunctionTypeUtilsto react to theParameterizedTypeand check its assignments againstFactorybean.Then resolves its generic to the proper target function type.
BeanFactoryAwareFunctionRegistryTests.functionFromFactoryBeanIsProperlyResolved()to verify thatFactoryBean<Function<?, ?>>is resolved properly