Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required fields to job cluster samples #301

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Add required fields to job cluster samples #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/samples/flinkoperator_v1beta1_flinkjobcluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
image:
name: flink:1.14.2
jobManager:
accessScope: Cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JaeguKim Thanks for this! Which version are you using? I believe this was addressed and shouldn't be required now with the latest beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using flink-cluster-crd.yaml which is latest beta I believe.
It looks like the accessScope is still required field of jobManager property and restartPolicy is also still required field of job property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see what's going on, helm CRD is outdated.

ports:
ui: 8081
resources:
Expand All @@ -38,5 +39,6 @@ spec:
className: org.apache.flink.streaming.examples.wordcount.WordCount
args: ["--input", "./README.txt"]
parallelism: 2
restartPolicy: Never
flinkProperties:
taskmanager.numberOfTaskSlots: "1"