Add required fields to job cluster samples #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
reviewed
Mar 7, 2022
| @@ -21,6 +21,7 @@ spec: | |||
| image: | |||
| name: flink:1.14.2 | |||
| jobManager: | |||
| accessScope: Cluster | |||
There was a problem hiding this comment.
Hi @JaeguKim Thanks for this! Which version are you using? I believe this was addressed and shouldn't be required now with the latest beta.
There was a problem hiding this comment.
I'm using flink-cluster-crd.yaml which is latest beta I believe.
It looks like the accessScope is still required field of jobManager property and restartPolicy is also still required field of job property.
There was a problem hiding this comment.
ah I see what's going on, helm CRD is outdated.
|
Thanks for this @JaeguKim sorry the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
flinkoperator_v1beta1_flinkjobcluster.yamlandflinkoperator_v1beta1_remotejobjar.yamlmissed required fields for v1beta1flinkclusters.flinkoperator.k8s.io.