Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-164] Add Polygon zkEVM #8

Merged
merged 8 commits into from
Oct 27, 2023
Merged

[SC-164] Add Polygon zkEVM #8

merged 8 commits into from
Oct 27, 2023

Conversation

barrutko
Copy link
Contributor

The Receiver contract is still missing

@barrutko barrutko self-assigned this Oct 26, 2023
hexonaut
hexonaut requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. This also lacks the receiver authentication, which needs to be added in a subsequent PR.

@hexonaut hexonaut mentioned this pull request Oct 26, 2023
Closed
@barrutko barrutko requested a review from hexonaut October 27, 2023 09:37
hexonaut
hexonaut requested changes Oct 27, 2023
View reviewed changes
@barrutko barrutko requested a review from hexonaut October 27, 2023 13:59
lucas-manuel
lucas-manuel requested changes Oct 27, 2023
View reviewed changes
lucas-manuel
lucas-manuel requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked forwarders and domain code against PR, LGTM, some changes

lucas-manuel
lucas-manuel requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked forwarders and domain code against PR, LGTM, some changes

hexonaut
hexonaut previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now after Lucas's changes.

lucas-manuel
lucas-manuel approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barrutko barrutko merged commit 119f506 into master Oct 27, 2023
@barrutko barrutko deleted the CS-164-add-zkEVM-helpers branch October 27, 2023 15:14
@0xdapper 0xdapper mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@lucas-manuel lucas-manuel lucas-manuel approved these changes

Assignees

@barrutko barrutko

Labels
Priority: Medium Status: Ready for Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrutko @hexonaut @lucas-manuel