Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ZkEvmReceiver #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add ZkEvmReceiver #11

wants to merge 5 commits into from

Conversation

0xdapper
Copy link

@0xdapper 0xdapper commented Oct 29, 2023 •
edited
Loading

Adds receiver #8

❯ forge test --mt test_zkevm -vvv
[⠆] Compiling...
No files changed, compilation skipped

Running 1 test for test/ZkEVMIntegration.t.sol:ZkEVMIntegrationTest
[PASS] test_zkevm() (gas: 3751228)
Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 20.95s

Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)

@barrutko barrutko self-requested a review October 30, 2023 15:10
@hexonaut hexonaut removed the request for review from lucas-manuel November 1, 2023 11:29
hexonaut
hexonaut requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a number of changes. Please note to other reviewers you can use https://github.com/0xPolygonHermez/code-examples/blob/main/pingPongExample/contracts/PingReceiver.sol#L65 for comparison.

@0xdapper @barrutko
chore: import formatting
5f36924 
Co-authored-by: Bartek Rutkowski <[email protected]>
@0xdapper 0xdapper requested a review from hexonaut November 2, 2023 09:34
hexonaut
hexonaut requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better. One more change, and this looks good to me.

@hexonaut hexonaut requested a review from barrutko November 10, 2023 13:21
hexonaut
hexonaut approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after Polygon has internal reviewer/auditor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@barrutko barrutko barrutko approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@0xdapper 0xdapper

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xdapper @hexonaut @barrutko