Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3465: removed product exposure time TEXPTIME #277

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Mar 4, 2024

Partially resolves JP-3465

This PR addresses removal of the TEXPTIME (product exposure time) keyword, since it is functionally redundant with XPOSURE and EFFEXPTM and is not used by any high-level data processing scripts we know about.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.70%. Comparing base (4d7c3a6) to head (f593a25).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   64.84%   64.70%   -0.14%     
==========================================
  Files         103      104       +1     
  Lines        5694     5701       +7     
==========================================
- Hits         3692     3689       -3     
- Misses       2002     2012      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review March 4, 2024 20:23
@emolter emolter requested a review from a team as a code owner March 4, 2024 20:23
@braingram
Copy link
Collaborator

It looks like spacetelescope/jwst#8212 removes the 2 uses in jwst.

Given the separate packages how should this PR be coordinated to avoid errors?

The current jwst dev pins stdatamodels to:
stdatamodels>=1.10.0,<1.11.0
all released version have pins <1.10 so this PR (which is targeting 1.10.1) will not impact any released versions of jwst. I think that means if we:

  • merge the jwst PR first, this should fix the CI here
  • merge this PR

will we see any issues?

Copy link
Contributor

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse
Copy link
Contributor

We should merge the changes to the jwst repo first, so that the pipeline code no longer tries accessing the keyword attribute, before we remove it from the datamodel schema here.

@hbushouse
Copy link
Contributor

spacetelescope/jwst#8212 has been merged, so it should be safe to merge this PR now. We'll need to update stdatamodels pins over in jwst once there's a new stdatamodels release.

@hbushouse hbushouse merged commit d223d62 into spacetelescope:main Mar 8, 2024
21 of 22 checks passed
@emolter emolter deleted the JP-3465 branch March 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants