-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3465: removed product exposure time TEXPTIME #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 64.84% 64.70% -0.14%
==========================================
Files 103 104 +1
Lines 5694 5701 +7
==========================================
- Hits 3692 3689 -3
- Misses 2002 2012 +10 ☔ View full report in Codecov by Sentry. |
It looks like spacetelescope/jwst#8212 removes the 2 uses in jwst. Given the separate packages how should this PR be coordinated to avoid errors? The current jwst dev pins stdatamodels to:
will we see any issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should merge the changes to the jwst repo first, so that the pipeline code no longer tries accessing the keyword attribute, before we remove it from the datamodel schema here. |
spacetelescope/jwst#8212 has been merged, so it should be safe to merge this PR now. We'll need to update stdatamodels pins over in jwst once there's a new stdatamodels release. |
Partially resolves JP-3465
This PR addresses removal of the TEXPTIME (product exposure time) keyword, since it is functionally redundant with XPOSURE and EFFEXPTM and is not used by any high-level data processing scripts we know about.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)