-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3465: Use TMEASURE in resample step #8212
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8212 +/- ##
==========================================
+ Coverage 75.15% 75.38% +0.22%
==========================================
Files 470 474 +4
Lines 38604 38937 +333
==========================================
+ Hits 29014 29351 +337
+ Misses 9590 9586 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look good to me. Just one minor suggestion for the change log entry. I think we could go ahead and merge these changes even before you're done making updates to regtest data files. Any test inputs that don't have TMEASURE in them yet should just fall back to using EFFEXPTIM.
I wonder if we should make an update to the resample/resample_spec docs to just mention which exposure time related keyword is actually used by the step when doing "exptime" weighting. There may not be any mention of it at all in the docs right now, but given how many different flavors of time-related keywords we have in the headers, I think it's worth explicitly saying in the docs which one is used. |
Starting new regtest run after removal of TEXPTIME keyword. Note stdatamodels install was overridden to use this branch. |
The latest regression test run results look good. All failures are just the absence of TEXPTIME in combined products, as expected, and a few instances of different values for the new TMEASURE keyword. So that looks good. |
Resolves JP-3465
Closes #8073
This PR adjusts the way exposure time weighting is computed in the resample step to use the new measurement_time keyword from JP-3449 instead of the exposure time.
Jenkins job
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR