Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3733 remove setting pixel_replace.save to True in calwebb_spec3 #8765

Merged
merged 3 commits into from
Sep 18, 2024
Merged

JP-3733 remove setting pixel_replace.save to True in calwebb_spec3 #8765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fee3779
remove setting pixel_replace.save to True
jemorrison Sep 10, 2024
4eff12d
Update change log
jemorrison Sep 10, 2024
9aef412
add back invariant_filename
jemorrison Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ ramp_fitting
- Moved the read noise variance recalculation for CHARGELOSS flagging to the C
implementation, when the algorithm is ``OLS_C``. [#8697, spacetelescope/stcal#278]

- Updated `calwebb_spec3` to not save the `pixel_replacement` output by default.[#8765]

resample
--------

Expand Down
2 changes: 0 additions & 2 deletions jwst/pipeline/calwebb_spec3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ def process(self, input):
self.spectral_leak.save_results = self.save_results
self.pixel_replace.suffix = 'pixel_replace'
self.pixel_replace.output_use_model = True
self.pixel_replace.save_results = self.save_results

# Overriding the Step.save_model method for the following steps.
# These steps save intermediate files, resulting in meta.filename
Expand Down Expand Up @@ -237,7 +236,6 @@ def process(self, input):
# interpolate pixels that have a NaN value or are flagged
# as DO_NOT_USE or NON_SCIENCE.
result = self.pixel_replace(result)

# Resample time. Dependent on whether the data is IFU or not.
resample_complete = None
if exptype in IFU_EXPTYPES:
Expand Down
Loading