JP-3733 remove setting pixel_replace.save to True in calwebb_spec3

[jemorrison]

Resolves JP-3733

Closes #8754

This PR addresses removes saving the pixel_replace step output by default. The user must set pixel_replace.save_results=True to get the output written to disk.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
• Does this PR change user-facing code / API?

  • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)

  • update or add relevant tests

  • update relevant docstrings and / or docs/ page

  • start a regression test and include a link to the running job (click here for instructions)

  • https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1719/

    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[jemorrison]

@tapastro Working on trying to figure out how to run regression tests in new system

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.76%. Comparing base (120ee5a) to head (9aef412).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8765   +/-   ##
=======================================
  Coverage   61.75%   61.76%           
=======================================
  Files         377      377           
  Lines       38749    38742    -7     
=======================================
- Hits        23931    23929    -2     
+ Misses      14818    14813    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[melanieclarke]

Is this line still needed? Say, if the user manually sets save_results = True, will the subsequent output filenames be affected?

[jemorrison]

I did not find any difference in the filenames (when pixel_replace.save_results=True) in having this line and or removed.
Since it is not doing any harm maybe we should leave it. Removing it may have unintended effects.
I will add it back in

[jemorrison]

@melanieclarke @tapastro
The regression test failures all are related to a different PR. I believe we can go ahead and merge this. But I can also re-run the regression test once the regression suite is cleaned up.
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1719/

[melanieclarke]

LGTM!

Testing locally on MIRI LRS data, which runs pixel_replace by default, no file is saved by default. Manually setting save_results=True for pixel_replace does save the file as expected.