Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove name_format usage in wfs_combine #8539

Merged
merged 1 commit into from
Jun 7, 2024
Merged

remove name_format usage in wfs_combine #8539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions jwst/wfs_combine/wfs_combine_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@
suffix = string(default="wfscmb")
"""

def make_output_path(self, basepath, *args, **kwargs):
# bypass all stpipe filename formatting
return basepath

Check warning on line 30 in jwst/wfs_combine/wfs_combine_step.py

View check run for this annotation

Codecov / codecov/patch

jwst/wfs_combine/wfs_combine_step.py#L30 

Added line #L30 was not covered by tests

def process(self, input_table):

self.suffix = 'wfscmb'
self.output_use_model = True
self.name_format = False

# Load the input ASN table
asn_table = self.load_as_level3_asn(input_table)
Expand Down Expand Up @@ -69,7 +72,8 @@
output_model.meta.cal_step.wfs_combine = 'COMPLETE'
output_model.meta.asn.pool_name = asn_table['asn_pool']
output_model.meta.asn.table_name = os.path.basename(input_table)
output_model.meta.filename = which_set['name']
# format the filename here
output_model.meta.filename = which_set['name'].format(suffix=self.suffix) + self.output_ext

output_container.append(output_model)

Expand Down