Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove name_format usage in wfs_combine #8539

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 6, 2024

This PR replaces usage of name_format in wfs_combine with make_output_path. The resulting filenames saved by the step are the same (as is tested in the test_nircam_wfs_image regression test). This PR removes the only use of name_format to allow its removal in stpipe to work towards simplifying the file naming code.

Regression tests show only unrelated errors and no failures of test_nircam_wfs_image.
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1502/

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.02%. Comparing base (4179c09) to head (b7e0b10).
Report is 326 commits behind head on master.

Files with missing lines Patch % Lines
jwst/wfs_combine/wfs_combine_step.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8539      +/-   ##
==========================================
+ Coverage   57.97%   58.02%   +0.04%     
==========================================
  Files         387      388       +1     
  Lines       38830    38977     +147     
==========================================
+ Hits        22513    22617     +104     
- Misses      16317    16360      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review June 6, 2024 13:55
@braingram braingram requested a review from a team as a code owner June 6, 2024 13:55
@hbushouse hbushouse added this to the Build 11.0 milestone Jun 6, 2024
@braingram braingram merged commit 4abaa90 into spacetelescope:master Jun 7, 2024
28 checks passed
@braingram braingram deleted the wfs_name_format branch June 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants