-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3613: Update error arrays to match NaN in data #8463
JP-3613: Update error arrays to match NaN in data #8463
Conversation
63132ed
to
6bc1c94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8463 +/- ##
==========================================
+ Coverage 56.38% 56.52% +0.14%
==========================================
Files 387 387
Lines 38716 38803 +87
==========================================
+ Hits 21830 21935 +105
+ Misses 16886 16868 -18 ☔ View full report in Codecov by Sentry. |
Regression tests started here: |
6bc1c94
to
99d75d4
Compare
I'm pretty sure the only relevant changes in the regression tests are new NaNs in intermediate error arrays, but there have been a lot of changes on master today - I can rerun when things settle down. |
99d75d4
to
d3d39a3
Compare
d3d39a3
to
1e4b0c2
Compare
Regression tests restarted here: |
Regression tests look right to me now: there are new NaNs in error and variance arrays in intermediate products between flat_field and cal for NIRSpec. The s2d and x1d files are not affected, since the pixels were already DO_NOT_USE. There are still a few unrelated failures: some changes from PR #8461, a failure in nirspec_mos_spec3 to be fixed in #8464, a failure in a miri_lrs wcs test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine and agree that regtest results are as expected.
Resolves JP-3613
Closes #8460
Update the error and variance arrays to NaN whenever science data is set to NaN. Impacts the flat field step and products up through the cal file, for all NIRSpec modes.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionupdated relevant documentationHow to run regression tests on a PR