Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3613: Update error arrays to match NaN in data #8463

Merged
merged 2 commits into from
May 8, 2024

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented May 6, 2024

Resolves JP-3613

Closes #8460

Update the error and variance arrays to NaN whenever science data is set to NaN. Impacts the flat field step and products up through the cal file, for all NIRSpec modes.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 56.52%. Comparing base (6580914) to head (d3d39a3).
Report is 10 commits behind head on master.

❗ Current head d3d39a3 differs from pull request most recent head 1e4b0c2. Consider uploading reports for the commit 1e4b0c2 to get more accurate results

Files Patch % Lines
jwst/flatfield/flat_field.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8463      +/-   ##
==========================================
+ Coverage   56.38%   56.52%   +0.14%     
==========================================
  Files         387      387              
  Lines       38716    38803      +87     
==========================================
+ Hits        21830    21935     +105     
+ Misses      16886    16868      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator Author

melanieclarke commented May 6, 2024

@melanieclarke melanieclarke added this to the Build 11.0 milestone May 7, 2024
@melanieclarke
Copy link
Collaborator Author

I'm pretty sure the only relevant changes in the regression tests are new NaNs in intermediate error arrays, but there have been a lot of changes on master today - I can rerun when things settle down.

@melanieclarke
Copy link
Collaborator Author

@melanieclarke
Copy link
Collaborator Author

Regression tests look right to me now: there are new NaNs in error and variance arrays in intermediate products between flat_field and cal for NIRSpec. The s2d and x1d files are not affected, since the pixels were already DO_NOT_USE.

There are still a few unrelated failures: some changes from PR #8461, a failure in nirspec_mos_spec3 to be fixed in #8464, a failure in a miri_lrs wcs test.

@melanieclarke melanieclarke self-assigned this May 8, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine and agree that regtest results are as expected.

@hbushouse hbushouse merged commit 241c5c0 into spacetelescope:master May 8, 2024
23 of 24 checks passed
@melanieclarke melanieclarke deleted the update_flat_nans branch May 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NIRSpec flat field: set error and variance to NaN to match data
2 participants