Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes: Replace type comparison with isinstance and increase lower pin for asdf #7801

Merged
merged 3 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
1.11.4 (unreleased)
===================

assign_wcs
----------

- Use isinstance instead of comparison with a type for lamp_mode
inspection [#7801]

calwebb_spec2
-------------

Expand All @@ -19,6 +25,11 @@ flat_field
- Modify the test_flatfield_step_interface unit test to prevent it from causing
other tests to fail [#7752]

general
-------

- Require minimum asdf version 2.14.4 [#7801]

master_background
-----------------

Expand Down
4 changes: 2 additions & 2 deletions jwst/assign_wcs/nirspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def get_open_slits(input_model, reference_files=None, slit_y_range=[-.55, .55]):
"""
exp_type = input_model.meta.exposure.type.lower()
lamp_mode = input_model.meta.instrument.lamp_mode
if type(lamp_mode) == str:
if isinstance(lamp_mode, str):
lamp_mode = lamp_mode.lower()
else:
lamp_mode = 'none'
Expand Down Expand Up @@ -1825,7 +1825,7 @@ def nrs_lamp(input_model, reference_files, slit_y_range):
The slit dimensions relative to the center of the slit.
"""
lamp_mode = input_model.meta.instrument.lamp_mode
if type(lamp_mode) == str:
if isinstance(lamp_mode, str):
lamp_mode = lamp_mode.lower()
else:
lamp_mode = 'none'
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ python_requires = >=3.9
setup_requires =
setuptools_scm
install_requires =
asdf>=2.14.1
asdf>=2.14.4
asdf-transform-schemas>=0.3.0
astropy>=5.2
BayesicFitting>=3.0.1
Expand Down