Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes: Replace type comparison with isinstance and increase lower pin for asdf #7801

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 8, 2023

I noticed the CI fail on the main branch due to likely a ruff update (which caused a new E721 rule violation due to a comparison using a type instead of use of isinstance) and the oldest deps failing (due to the asdf dependency, jsonschema, updating).

This PR switches the type comparisons to calls to isinstance and increases the lower asdf version to 2.14.4.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram changed the title Ci fixes Replace type comparison with isinstance and increase lower pin for asdf Aug 8, 2023
@braingram braingram marked this pull request as ready for review August 8, 2023 21:24
@braingram braingram requested a review from a team as a code owner August 8, 2023 21:24
@braingram braingram changed the title Replace type comparison with isinstance and increase lower pin for asdf CI fixes: Replace type comparison with isinstance and increase lower pin for asdf Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (e4defd6) 76.58% compared to head (eb6210d) 76.58%.

❗ Current head eb6210d differs from pull request most recent head 05bc5f1. Consider uploading reports for the commit 05bc5f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7801      +/-   ##
==========================================
- Coverage   76.58%   76.58%   -0.01%     
==========================================
  Files         456      456              
  Lines       36920    36920              
==========================================
- Hits        28275    28274       -1     
- Misses       8645     8646       +1     
Flag Coverage Δ *Carryforward flag
nightly 77.39% <ø> (-0.01%) ⬇️ Carriedforward from c9fa467

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
jwst/assign_wcs/nirspec.py 93.90% <50.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.0 milestone Aug 9, 2023
@braingram
Copy link
Collaborator Author

@hbushouse hbushouse merged commit 9a85cc8 into spacetelescope:master Aug 10, 2023
@braingram braingram deleted the ci_fixes branch August 10, 2023 15:28
mairanteodoro pushed a commit to mairanteodoro/jwst that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants