CI fixes: Replace type comparison with isinstance and increase lower pin for asdf #7801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the CI fail on the main branch due to likely a ruff update (which caused a new E721 rule violation due to a comparison using a type instead of use of
isinstance
) and the oldest deps failing (due to the asdf dependency, jsonschema, updating).This PR switches the type comparisons to calls to
isinstance
and increases the lower asdf version to 2.14.4.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR