JP-2104: Do not consider GROUP candidates for WFS&C observations #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stscieisenhamer Not entirely clear to me why 'member' is a required argument to a validity update, but it seems to force 2 arguments into the function so I need to allow for it. Otherwise working as intended? |
Codecov Report
@@ Coverage Diff @@
## master #6131 +/- ##
==========================================
+ Coverage 77.11% 77.12% +0.01%
==========================================
Files 402 402
Lines 34661 34681 +20
==========================================
+ Hits 26730 26749 +19
- Misses 7931 7932 +1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
|
The validation bit has some tech-debt in there which needs refactor at some point in the distant future. Will review momentarily. |
…/tapastro/jwst into jp-2104-no-group-candidates-wfsc new rc -> rebase and pull
hbushouse
approved these changes
Jun 11, 2021
nden
pushed a commit
that referenced
this pull request
Jul 27, 2021
* add validation check on acid type = group * changelog and restart CI - codecov bug? * add validation check on acid type = group * changelog and restart CI - codecov bug? * [skip ci] update changelog to 1.2.3 header (cherry picked from commit 9d34aa4)
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
…cetelescope#6131) * add validation check on acid type = group * changelog and restart CI - codecov bug? * add validation check on acid type = group * changelog and restart CI - codecov bug? * [skip ci] update changelog to 1.2.3 header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6075
Resolves JP-2104
Description
This PR adds an extra validation check for Lv3_WFSCMB to ensure that the association id type is not 'group'.
Checklist
Tests
Documentation
Change log
Milestone
Label(s)