Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2035: Ramp fit ols gls sep #5951

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented Apr 9, 2021

Closes #5943

Resolves JP-2035

Description

This PR separates the OLS and GLS algorithms to their own files, instead of both in the one ramp_fit.py file.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #5951 (5f2bb30) into master (c5cfcd5) will increase coverage by 0.19%.
The diff coverage is 61.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5951      +/-   ##
==========================================
+ Coverage   77.91%   78.10%   +0.19%     
==========================================
  Files         403      404       +1     
  Lines       35359    37038    +1679     
==========================================
+ Hits        27549    28929    +1380     
- Misses       7810     8109     +299     
Flag Coverage Δ *Carryforward flag
nightly 77.91% <63.52%> (ø) Carriedforward from e41f568
unit 56.06% <54.58%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/ramp_fitting/ols_fit.py 82.89% <ø> (ø)
jwst/ramp_fitting/ramp_fit.py 77.53% <ø> (+0.21%) ⬆️
jwst/ramp_fitting/gls_fit.py 68.24% <59.49%> (-2.04%) ⬇️
jwst/ramp_fitting/utils.py 96.41% <75.67%> (-0.20%) ⬇️
jwst/resample/resample_spec_step.py 90.51% <0.00%> (-4.67%) ⬇️
jwst/associations/lib/rules_level2b.py 93.84% <0.00%> (-2.87%) ⬇️
jwst/associations/lib/rules_level3.py 98.75% <0.00%> (-0.49%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cfcd5...5f2bb30. Read the comment docs.

Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This segregation of OLS and GLS code is an improvement, and will make it easier to maintain the code. In a later PR, refactoring fit_next_segment() should help reduce the size of the new module ols_fit.py, where the OLS-specific functions now live. Don't forget to update the change log.

@hbushouse hbushouse added this to the Build 7.8 milestone Apr 12, 2021
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden nden merged commit 1852a76 into spacetelescope:master Apr 12, 2021
@nden nden mentioned this pull request Apr 13, 2021
5 tasks
@kmacdonald-stsci kmacdonald-stsci deleted the ramp_fit_ols_gls_sep branch April 14, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate the OLS and GLS code into their own separate files from ramp_fit.py
4 participants