-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2035: Ramp fit ols gls sep #5951
JP-2035: Ramp fit ols gls sep #5951
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5951 +/- ##
==========================================
+ Coverage 77.91% 78.10% +0.19%
==========================================
Files 403 404 +1
Lines 35359 37038 +1679
==========================================
+ Hits 27549 28929 +1380
- Misses 7810 8109 +299
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This segregation of OLS and GLS code is an improvement, and will make it easier to maintain the code. In a later PR, refactoring fit_next_segment() should help reduce the size of the new module ols_fit.py, where the OLS-specific functions now live. Don't forget to update the change log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #5943
Resolves JP-2035
Description
This PR separates the OLS and GLS algorithms to their own files, instead of both in the one
ramp_fit.py
file.Checklist