Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the OLS and GLS code into their own separate files from ramp_fit.py #5943

Closed
stscijgbot-jp opened this issue Apr 8, 2021 · 1 comment · Fixed by #5951
Closed

Separate the OLS and GLS code into their own separate files from ramp_fit.py #5943

stscijgbot-jp opened this issue Apr 8, 2021 · 1 comment · Fixed by #5951
Labels
team_periwinkle

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-2035 was created on JIRA by Kenneth MacDonald:

Most of the ramp fitting code is currently in ramp_fit.py, but there is a natural separation of the code based on which least square algorithm is being used.  These two algorithms, ordinary least squares and generalized least squares, should be in separate files.
@kmacdonald-stsci kmacdonald-stsci mentioned this issue Apr 9, 2021
Merged
5 tasks
@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Fixed by #5951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team_periwinkle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JP-2035: Ramp fit ols gls sep kmacdonald-stsci/jwst
1 participant
@stscijgbot-jp