Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to SVM #89

Closed
10 of 15 tasks
noamnelke opened this issue Sep 25, 2021 · 1 comment
Closed
10 of 15 tasks

Transition to SVM #89

noamnelke opened this issue Sep 25, 2021 · 1 comment
Assignees

Comments

@noamnelke
Copy link
Member

noamnelke commented Sep 25, 2021

The transition to SVM will be performed in 3 major phases:

Phase 1

Phase 2

The last two issues can be worked on in parallel, although minor conflicts are to be expected.

Phase 3

Prerequisites

go-svm being fully implemented and exposing the following functions (click to expand)
SVM codec for encoding transactions implemented and ready (click to expand)

Should be exposed by go-svm as a utility, for go-spacemesh and sm-repl to use.

SVM codec instantiation boilerplate code: https://github.com/spacemeshos/go-svm-old/tree/master/codec

Tasks

  • Add go-svm to go-spacemesh as a dependency (mostly about getting the build/linkage to work).
  • Encode transactions using SVM codec.
  • Create an SVM package replacement with identical method signature and re-implement all methods using go-svm exposed methods.
  • Ensure all unit tests and system tests pass.
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Jan 20, 2022
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Jan 20, 2022
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this issue Jan 20, 2022
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@lrettig
Copy link
Member

lrettig commented Oct 17, 2023

largely done, and what's remaining here will be obviated by new VM design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants