Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix building project when go-svm is imported #3052

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Fix building project when go-svm is imported #3052

wants to merge 9 commits into from

Conversation

nkryuchkov
Copy link
Contributor

Motivation

WIP on spacemeshos/pm#89:

Add go-svm to go-spacemesh as a dependency (mostly about getting the build/linkage to work).

Changes

  • Import github.com/spacemeshos/go-svm/svm
  • Fix Makefiles for the import

Test Plan

UT

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@nkryuchkov nkryuchkov changed the title Fix building project when github.com/spacemeshos/go-svm/svm is imported Fix building project when go-svm is imported Jan 10, 2022
@nkryuchkov nkryuchkov changed the title Fix building project when go-svm is imported Fix building project when go-svm is imported Jan 10, 2022
@nkryuchkov
Copy link
Contributor Author

TODO: create a test release from this branch and check if it works

@nkryuchkov
Copy link
Contributor Author

dockerpush failed: https://github.com/spacemeshos/go-spacemesh/runs/4791511767?check_suite_focus=true

# github.com/spacemeshos/go-svm/svm
/go/src/github.com/spacemeshos/go-spacemesh/build//libsvm.a(sqlite3.o):(.data.rel.aSyscall+0xb0): undefined reference to `fcntl64'
collect2: error: ld returned 1 exit status
make: *** [go-spacemesh] Error 2
Makefile:105: recipe for target 'go-spacemesh' failed
The command '/bin/sh -c make build' returned a non-zero code: 2
make: *** [Makefile:209: dockerbuild-go] Error 2
Error: Process completed with exit code 2.

@nkryuchkov
Copy link
Contributor Author

go-spacemesh in the release for macOS seems working (https://github.com/spacemeshos/go-spacemesh/releases/tag/untagged-c3a6339bc6579db217e5)

@nkryuchkov
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 12, 2022
@bors
Try #3052:
32ab882
@bors
Copy link

bors bot commented Jan 13, 2022

try

Build failed:

@nkryuchkov
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 13, 2022
@bors
Try #3052:
ea58898
@bors
Copy link

bors bot commented Jan 13, 2022

try

Build failed:

@nkryuchkov
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 13, 2022
@bors
Try #3052:
2dd1cf7
@bors
Copy link

bors bot commented Jan 13, 2022

try

Build succeeded:

@nkryuchkov
Copy link
Contributor Author

dockerpush failed: https://github.com/spacemeshos/go-spacemesh/runs/4791511767?check_suite_focus=true

# github.com/spacemeshos/go-svm/svm
/go/src/github.com/spacemeshos/go-spacemesh/build//libsvm.a(sqlite3.o):(.data.rel.aSyscall+0xb0): undefined reference to `fcntl64'
collect2: error: ld returned 1 exit status
make: *** [go-spacemesh] Error 2
Makefile:105: recipe for target 'go-spacemesh' failed
The command '/bin/sh -c make build' returned a non-zero code: 2
make: *** [Makefile:209: dockerbuild-go] Error 2
Error: Process completed with exit code 2.

fixed

@nkryuchkov
Copy link
Contributor Author

New release https://github.com/spacemeshos/go-spacemesh/releases/tag/untagged-fea03f4b289681e3b984 seems working on macOS too

dshulyak
dshulyak reviewed Jan 20, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
neysofu
neysofu approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nkryuchkov
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix building project when go-svm is imported (#3052)
bbd07fb 
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Jan 20, 2022

Build failed:

@nkryuchkov
Copy link
Contributor Author

Build failed:

looks like an infra failure

@nkryuchkov
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix building project when go-svm is imported (#3052)
9e81661 
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Jan 20, 2022

Build failed:

@nkryuchkov
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix building project when go-svm is imported (#3052)
bdb7356 
## Motivation
<!-- Please mention the issue fixed by this PR or detailed motivation -->
WIP on spacemeshos/pm#89:
> Add `go-svm` to `go-spacemesh` as a dependency (mostly about getting the build/linkage to work).

<!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged -->

## Changes
<!-- Please describe in detail the changes made -->
- Import github.com/spacemeshos/go-svm/svm
- Fix Makefiles for the import

## Test Plan
<!-- Please specify how these changes were tested 
(e.g. unit tests, manual testing, etc.) -->
UT

## DevOps Notes
<!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases -->
- [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
- [x] This PR does not affect public APIs
- [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
- [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
@bors
Copy link

bors bot commented Jan 20, 2022

Pull request successfully merged into develop.

Build succeeded:

@bors bors bot changed the title Fix building project when go-svm is imported [Merged by Bors] - Fix building project when go-svm is imported Jan 20, 2022
@bors bors bot closed this Jan 20, 2022
@bors bors bot deleted the feature/build-with-go-svm branch January 20, 2022 18:21
@nkryuchkov nkryuchkov mentioned this pull request Jan 20, 2022
Closed
bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix Makefile path in go-env-test.run.xml (#3069)
6475243 
## Motivation
I forgot to update the Makefile path in #3052

## Changes
<!-- Please describe in detail the changes made -->
- Fix Makefile path in `go-env-test.run.xml`
bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix Makefile path in go-env-test.run.xml (#3069)
45df46e 
## Motivation
I forgot to update the Makefile path in #3052

## Changes
<!-- Please describe in detail the changes made -->
- Fix Makefile path in `go-env-test.run.xml`
bors bot pushed a commit that referenced this pull request Jan 20, 2022
@nkryuchkov
Fix Makefile path in go-env-test.run.xml (#3069)
4a4f200 
## Motivation
I forgot to update the Makefile path in #3052

## Changes
<!-- Please describe in detail the changes made -->
- Fix Makefile path in `go-env-test.run.xml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak dshulyak left review comments

@neysofu neysofu neysofu approved these changes

@noamnelke noamnelke Awaiting requested review from noamnelke

@moshababo moshababo Awaiting requested review from moshababo

@countvonzero countvonzero Awaiting requested review from countvonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkryuchkov @dshulyak @moshababo @neysofu