Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Commit, Rewind, CreateAccount and others #29

Merged
merged 7 commits into from
Nov 29, 2021
Merged

Conversation

neysofu
Copy link
Contributor

@neysofu neysofu commented Nov 5, 2021

Closes #17, #16, #15, #14. #18 still missing.

@neysofu neysofu added the svm label Nov 5, 2021
@neysofu neysofu self-assigned this Nov 5, 2021
@neysofu neysofu changed the title Integrate Open, Commit, CreateAccount and others Integrate Commit, Rewind, CreateAccount and others Nov 8, 2021
@neysofu neysofu marked this pull request as ready for review November 8, 2021 11:58
@neysofu
Copy link
Contributor Author

neysofu commented Nov 24, 2021

CI momentarily failing due to spacemeshos/svm#422 yet unmerged.

@neysofu neysofu mentioned this pull request Nov 29, 2021
@neysofu
Copy link
Contributor Author

neysofu commented Nov 29, 2021

Closes #18 as well, we might add some additional checks and asserts down the line though.

Copy link
Contributor

@YaronWittenstein YaronWittenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate the Commit API
2 participants