Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the SVM Get Account #15

Closed
YaronWittenstein opened this issue Oct 20, 2021 · 1 comment
Closed

Integrate the SVM Get Account #15

YaronWittenstein opened this issue Oct 20, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers svm

Comments

@YaronWittenstein
Copy link
Contributor

The SVM FFI layer exposes the svm_get_accunt:
https://github.com/spacemeshos/svm/blob/478d12fddfa87e6230a64010bfd3c0f24ad3164f/crates/runtime-ffi/src/api.rs#L437

We want to go-svm to integrate with that API so that go-spacemesh could use it.

Right now, there is a place-holder for GetAccount:

go-svm/svm/api.go

Line 260 in 710604c

func (rt *Runtime) GetAccount(addr Address) (Account, error) {

@YaronWittenstein YaronWittenstein added enhancement New feature or request good first issue Good for newcomers svm labels Oct 20, 2021
@YaronWittenstein YaronWittenstein changed the title Integrate Get Account Integrate the SVM Get Account Oct 20, 2021
@neysofu neysofu mentioned this issue Nov 8, 2021
Merged
@neysofu
Copy link
Contributor

neysofu commented Dec 2, 2021

Closed by #29.

@neysofu neysofu closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers svm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YaronWittenstein @neysofu